[PATCH] D135893: [FuncSpec] Fix specialisation based on literals

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM if @labrinea's comment get addressed.



================
Comment at: llvm/test/Transforms/FunctionSpecialization/literal-const.ll:86-92
+; Check all of `neg`, `add`, and `addf` were specialised.
+; CHECK-LIT-DAG: @neg.[[#A]]
+; CHECK-LIT-DAG: @neg.[[#B]]
+; CHECK-LIT-DAG: @add.[[#C]]
+; CHECK-LIT-DAG: @add.[[#D]]
+; CHECK-LIT-DAG: @addf.[[#E]]
+; CHECK-LIT-DAG: @addf.[[#F]]
----------------
labrinea wrote:
> Maybe add "define" before the specialized function names to make sure we match the definitions?
> Maybe add "define" before the specialized function names to make sure we match the definitions?

+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135893/new/

https://reviews.llvm.org/D135893