[PATCH] D136805: [NFC] Make format() more amenable to format attributes

[Akira Hatanaka via Phabricator via llvm-commits]

ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.

Probably not NFC according to https://llvm.org/docs/Lexicon.html, but LGTM.



================
Comment at: llvm/lib/Support/Format.cpp:59
+
+constexpr uint64_t specifierBit(char C) { return (uint64_t)1 << (C - 0x40); }
+
----------------
Can you add an explanation for what the number `0x40` means or why it was chosen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136805/new/

https://reviews.llvm.org/D136805