[PATCH] D136242: [IntervalMap] Add move and copy ctors and assignment operators

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 14:54:49 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.

That all looks about right to me.



================
Comment at: llvm/include/llvm/ADT/IntervalMap.h:1064-1066
+    // Future-proofing assertion: this function assumes the IntervalMap
+    // constructor doesn't add any nodes.
+    assert(empty() && "Expected emptry tree");
----------------
This /probably/ isn't needed - seems pretty unlikely that an allocator-constructer IntervalMap would be anything other than empty, but no worries if you feel strongly about keeping it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136242/new/

https://reviews.llvm.org/D136242



More information about the llvm-commits mailing list