[PATCH] D136781: ensure loop-simplifed form when running loop-fusion pass with new-PM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

test needs a little work, otherwise lg



================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:557
 public:
   LoopFuser(LoopInfo &LI, DominatorTree &DT, DependenceInfo &DI,
             ScalarEvolution &SE, PostDominatorTree &PDT,
----------------
I guess `DependenceInfo` doesn't need to be updated because it has no state


================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:1
+; RUN: opt -enable-new-pm=1 -loop-fusion  < %s
+
----------------



================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:1
+; RUN: opt -enable-new-pm=1 -loop-fusion  < %s
+
----------------
aeubanks wrote:
> 
can you use `llvm/utils/update_test_checks.py`?


================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:3
+
+define dso_local void @v_5_0() {
+entry:
----------------
remove dso_local


================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:8
+for.cond.cleanup:                                 ; preds = %for.body
+  br i1 undef, label %for.body6, label %for.cond.cleanup5
+
----------------
we're trying to use `undef` less, perhaps make this a constant `true`/`false` or a function parameter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136781/new/

https://reviews.llvm.org/D136781