[PATCH] D136396: [X86] Enable reassociation for ADD instructions

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Enjoyably not a Dexter bug -- the output with -v indicates that there's a sequence in the "main" function of that test where the `main_result` variable becomes unavailable with this patch. That would appear to be because TargetInstrInfo::reassociateOps isn't instrumented for instruction referencing, which I'll file as a fault. This patch just exposes that omission.

Sadly though, this Dexter test isn't supposed to be checking for this sort of error, it's supposed to be making sure the other functions in the file have reasonable debug-info. The only reason we see this is because we didn't mark `main` with `__attribute__((optnone))`. I'll add that attribute and un-xfail the test as I'm out of cycles; thanks for pinging!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136396/new/

https://reviews.llvm.org/D136396