[PATCH] D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN

[Alexey Baturo via Phabricator via llvm-commits]

smd added a comment.

> Does the tagging actually change the location of globals?

No, it doesn't.

> I was assuming the location was the same, and the tag was just changing how we encoded that location in a numerical value.

Yes, you're right.

> My understanding of the code model specifications is that they only care about the actual address ranges.
> So if the location doesn't actually change in principle you could materialize those with a different instruction sequence and still claim you comply with the code model, is that not the case?

I guess that you're right. However from what I can tell, this would require to make linker to distinguish different kind of addresses of variables. I guess that's why ARM has a separate symbol for such tags.

> That only impacts the comments in the patch, I'm not opposed to the approach of using the GOT.

I'll fix the comments as you suggested, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132995/new/

https://reviews.llvm.org/D132995