[PATCH] D63525: LangRef: Attempt to formulate some rules for addrspacecast

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

volatile restriction seems fine.  New addrspace casting rules seem fine.



================
Comment at: llvm/docs/LangRef.rst:3047
+address spaces are target-specific. Memory access through an invalid,
+non-dereferenceable "null" pointer is undefined behavior in any address
+space. Pointers with the bit-value 0 are only assumed to be
----------------
Given we don't define what it means for a pointer to be "null", or promise that such a pointer exists in every address-space, it isn't really meaningful to say that dereferencing null is undefined.  We can just drop that whole sentence, I think.


================
Comment at: llvm/docs/LangRef.rst:10268
+operand refer to the same memory location. The conversion must have no
+side effects, or capture the value of the pointer.
+
----------------
"The conversion must have no side effects, and must not capture the value of the pointer."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63525/new/

https://reviews.llvm.org/D63525