[PATCH] D135929: [profile] Add binary ids into indexed profiles
Ellis Hoag via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 26 11:50:45 PDT 2022
ellis added inline comments.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:344
+
+ std::vector<llvm::object::BuildIDRef> BinaryIds;
+ if (Error E = Reader->readBinaryIds(BinaryIds))
----------------
`SmallVector<T, 0>` seems to be preferred over `std::vector<T>` even if the number of elements is large.
https://www.llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135929/new/
https://reviews.llvm.org/D135929
More information about the llvm-commits
mailing list