[PATCH] D136394: [BOLT][PseudoProbe] Support new pseudo probe encoding

Wed Oct 26 11:10:28 PDT 2022

hoy added a subscriber: maksim.
hoy added a comment.

@maksim Does the current version look good to you? Any more comments? Thanks.

================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:613
+  MCPseudoProbeDecoder::Uint64Map FuncStartAddrs;
+  for (const BinaryFunction *F : BC->getAllBinaryFunctions()) {
+    for (const MCSymbol *Sym : F->getSymbols()) {
----------------
wenlei wrote:
> maksfb wrote:
> > wenlei wrote:
> > > A quick question for bolt folks - does BinarayFunction represent individual segments of split functions; or does BinaryFunction simply maps to original function, with MCSymbol under a binary function representing each split funclets? Asking because we want to make sure naming convention is consistent for probe emission and bolt.
> > We have a limited support for inputs with split functions. At the moment, we have one `BinaryFunction` for each function fragment, but it doesn't work well for a number of reasons, and for a proper support we will eventually have to merge the fragments into a single instance of a `BinaryFunction`. When BOLT splits functions, each fragment will come from the same instance of `BinaryFunction`.
> Thanks for clarification. @hoy then I'd suggest let's not use the term binary function for split funclets during probe emission.
Sounds good. Changed to using split function.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136394/new/

https://reviews.llvm.org/D136394