[PATCH] D136745: [NFC] [AAPointerInfo] OffsetAndSize is no longer an std::pair

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 10:46:25 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:732
+    return AA::OffsetAndSize{TombstoneKey, TombstoneKey};
+  }
+
----------------
sameerds wrote:
> jdoerfert wrote:
> > Do we need to ensure empty and tombstone key do not clash with unknown/unassigned?
> That kinda goes without saying whenever a DenseMap is used. But I've now added comments to the place where Unknown and Unsigned are declared.
In case these are all compile time constants we could even use a static_assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136745/new/

https://reviews.llvm.org/D136745



More information about the llvm-commits mailing list