[PATCH] D135914: [PseudoProbe] Decode offset based pseudo probe.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 10:40:07 PDT 2022


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm, with a nit on naming.



================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:481
+        // For sentinel probe, the addr field actually stores the GUID of the
+        // binary function. Convert it to the real address.
+        if (auto V = FuncStartAddrs.lookup(Addr))
----------------
nit: binary function -> split function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135914/new/

https://reviews.llvm.org/D135914



More information about the llvm-commits mailing list