[PATCH] D135912: [PseudoProbe] Replace relocation with offset for entry probe.

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: llvm/include/llvm/IR/PseudoProbe.h:33
+  Reserved = 0x1,
+  Sentinel = 0x2, // A place holder for function entry address.
+};
----------------
nit on comment: split function entry address? main body doesn't have it.


================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:80
   } else {
-    // Emit label as a symbolic code address.
-    MCOS->emitSymbolValue(
-        Label, MCOS->getContext().getAsmInfo()->getCodePointerSize());
+    // Emit the GUID of the code range that the sentinel probe represents.
+    MCOS->emitInt64(Guid);
----------------
hoy wrote:
> wenlei wrote:
> > To be accurate, this is the GUID of the (split) binary function name / elf symbol name? 
> Exactly.
nit on comment: function -> split function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135912/new/

https://reviews.llvm.org/D135912