[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:619
 
+Previously when emitting DWARFv4 and tuning for GDB, Clang would use DWARFv2's
+``DW_AT_bit_offset`` and ``DW_AT_data_member_location``. Clang now uses DWARFv4's
----------------
"DWARF v4" is more common than "DWARFv4". ditto below


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:431
 
-  // GDB does not fully support the DWARF 4 representation for bitfields.
-  UseDWARF2Bitfields = (DwarfVersion < 4) || tuneForGDB();
+  UseDWARF2Bitfields = (DwarfVersion < 4);
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135583/new/

https://reviews.llvm.org/D135583