[PATCH] D136698: [SampleFDO] Persist profile staleness metrics into binary

[Lei Wang via Phabricator via llvm-commits]

wlei added a comment.

In D136698#3883954 <https://reviews.llvm.org/D136698#3883954>, @davidxl wrote:

> For incremental build, are the artifacts (build logs) also cached?

Our infra doesn't support this right now.

> Anyway, I can see the usefulness of the post-build analysis case. However should we consider more general mechanism for message persistence? I will copy some folks in the review.

Thanks for the feedback, yes, this key/value structure intends to be extended for other stats, I'd appreciate more feedback to make it general.



================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:534
       Ctx->getELFSection(".pseudo_probe_desc", DebugSecType, 0);
+  ProfStatsSection = Ctx->getELFSection(".prof_stats", DebugSecType, 0);
 }
----------------
wenlei wrote:
> prof_stats might still be a bit narrow. persistent key-value in obj can be a general mechanism used for other purpose as well. maybe `llvm-stats`?
Sounds good, renamed all to `llvm-stats`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136698/new/

https://reviews.llvm.org/D136698