[PATCH] D136677: [AMDGPU] Small cleanups in wait counter code
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 26 10:01:43 PDT 2022
scott.linder added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:698-715
switch (T) {
case VM_CNT:
- OS << " VM_CNT(" << UB - LB << "): ";
+ OS << " VM_CNT(" << SR << "): ";
break;
case LGKM_CNT:
+ OS << " LGKM_CNT(" << SR << "): ";
----------------
stepthomas wrote:
> scott.linder wrote:
> > Nit, but I'd also factor out the remaining common stuff
> I'll decline this suggestion if I may - it actually makes it less clear to me.
Works for me, I agree it is nice to see the whole "token" for each case in one line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136677/new/
https://reviews.llvm.org/D136677
More information about the llvm-commits
mailing list