[PATCH] D136762: [LLD][COFF] Survive empty PCH signature

Wed Oct 26 09:23:11 PDT 2022

aganea added a comment.

Thanks for the review!

In D136762#3885821 <https://reviews.llvm.org/D136762#3885821>, @rnk wrote:

> So, the signature moved from S_OBJNAME to LF_ENDPRECOMP, but everything else more or less stays the same.
>
> Sounds good to me.

Actually the code supports both now, depending on the version of the MSVC compiler.

I'll hold on this for a bit, I'm still seeing weird warnings and the .PDB is only 450 MiB with LLD -- instead of 2 GiB with link.exe. I think the issues are unrelated, but i'd like to get to the bottom of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136762/new/

https://reviews.llvm.org/D136762