[PATCH] D136745: [NFC] [AAPointerInfo] OffsetAndSize is no longer an std::pair

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

It's a nice cleanup. I have one concern below.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:263
+inline bool operator!=(const OffsetAndSize &A, const OffsetAndSize &B) {
+  return A == B ? false : true;
+}
----------------



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:732
+    return AA::OffsetAndSize{TombstoneKey, TombstoneKey};
+  }
+
----------------
Do we need to ensure empty and tombstone key do not clash with unknown/unassigned?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136745/new/

https://reviews.llvm.org/D136745