[PATCH] D136753: [DemandedBits] Add Div instruction to DetermineLiveOperandBits
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 26 06:44:38 PDT 2022
RKSimon added a comment.
In D136753#3885422 <https://reviews.llvm.org/D136753#3885422>, @zjaffal wrote:
> In D136753#3885186 <https://reviews.llvm.org/D136753#3885186>, @RKSimon wrote:
>
>> Please can you add udiv/sdiv exhaustive test coverage to llvm-project\llvm\unittests\IR\DemandedBitsTest.cpp
>
> Would be possible to use the same logic used for add and sub or I need to create something new? Also do you think we should add ir tests as well or that wouldn't be necessary
You'll probably have to create a similar ForeachKnownBits system from scratch
Adding IR tests to test\Analysis\DemandedBits is always welcome - its pretty empty in there
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136753/new/
https://reviews.llvm.org/D136753
More information about the llvm-commits
mailing list