[PATCH] D136681: [GlobalISel] Add Predicates to GICombineRule

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 03:13:34 PDT 2022


foad added a comment.

In D136681#3883037 <https://reviews.llvm.org/D136681#3883037>, @dsanders wrote:

> LGTM, ideally as you say this ought to be part of the partitioning so the generated can code efficiently get to the relevant leaves more directly but this is fine for now

Maybe leave a TODO in the code to that effect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136681/new/

https://reviews.llvm.org/D136681



More information about the llvm-commits mailing list