[PATCH] D136180: [FuncSpec] Compute specialisation gain even when forcing specialisation
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 26 02:18:00 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG606d25e545d3: [FuncSpec] Compute specialisation gain even when forcing specialisation (authored by chill).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136180/new/
https://reviews.llvm.org/D136180
Files:
llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
llvm/test/Transforms/FunctionSpecialization/specialization-order.ll
Index: llvm/test/Transforms/FunctionSpecialization/specialization-order.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/FunctionSpecialization/specialization-order.ll
@@ -0,0 +1,58 @@
+; RUN: opt -S --passes=function-specialization,deadargelim -force-function-specialization < %s | FileCheck %s
+define dso_local i32 @add(i32 %x, i32 %y) {
+entry:
+ %add = add nsw i32 %y, %x
+ ret i32 %add
+}
+
+define dso_local i32 @sub(i32 %x, i32 %y) {
+entry:
+ %sub = sub nsw i32 %x, %y
+ ret i32 %sub
+}
+
+define internal i32 @f(i32 %x, i32 %y, ptr %u, ptr %v) noinline {
+entry:
+ %call = tail call i32 %u(i32 %x, i32 %y)
+ %call1 = tail call i32 %v(i32 %x, i32 %y)
+ %mul = mul nsw i32 %call1, %call
+ ret i32 %mul
+}
+
+define dso_local i32 @g0(i32 %x, i32 %y) {
+; CHECK-LABEL: @g0
+; CHECK: call i32 @f.2(i32 [[X:%.*]], i32 [[Y:%.*]])
+entry:
+ %call = tail call i32 @f(i32 %x, i32 %y, ptr @add, ptr @add)
+ ret i32 %call
+}
+
+
+define dso_local i32 @g1(i32 %x, i32 %y) {
+; CHECK-LABEL: @g1(
+; CHECK: call i32 @f.1(i32 [[X:%.*]], i32 [[Y:%.*]])
+entry:
+ %call = tail call i32 @f(i32 %x, i32 %y, ptr @sub, ptr @add)
+ ret i32 %call
+}
+
+define dso_local i32 @g2(i32 %x, i32 %y, ptr %v) {
+; CHECK-LABEL @g2
+; CHECK call i32 @f.3(i32 [[X:%.*]], i32 [[Y:%.*]], ptr [[V:%.*]])
+entry:
+ %call = tail call i32 @f(i32 %x, i32 %y, ptr @sub, ptr %v)
+ ret i32 %call
+}
+
+; CHECK-LABEL: define {{.*}} i32 @f.1
+; CHECK: call i32 @sub(i32 %x, i32 %y)
+; CHECK-NEXT: call i32 @add(i32 %x, i32 %y)
+
+; CHECK-LABEL: define {{.*}} i32 @f.2
+; CHECK: call i32 @add(i32 %x, i32 %y)
+; CHECK-NEXT call i32 @add(i32 %x, i32 %y)
+
+; CHECK-LABEL: define {{.*}} i32 @f.3
+; CHECK: call i32 @sub(i32 %x, i32 %y)
+; CHECK-NEXT: call i32 %v(i32 %x, i32 %y)
+
Index: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
===================================================================
--- llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
+++ llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
@@ -446,16 +446,16 @@
SpecializationInfo &S = I.first->second;
if (I.second)
- S.Gain = ForceFunctionSpecialization ? 1 : 0 - Cost;
- if (!ForceFunctionSpecialization)
- S.Gain += getSpecializationBonus(&FormalArg, ActualArg);
+ S.Gain = 0 - Cost;
+ S.Gain += getSpecializationBonus(&FormalArg, ActualArg);
S.Args.push_back({&FormalArg, ActualArg});
}
}
// Remove unprofitable specializations.
- Specializations.remove_if(
- [](const auto &Entry) { return Entry.second.Gain <= 0; });
+ if (!ForceFunctionSpecialization)
+ Specializations.remove_if(
+ [](const auto &Entry) { return Entry.second.Gain <= 0; });
// Clear the MapVector and return the underlying vector.
WorkList = Specializations.takeVector();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136180.470751.patch
Type: text/x-patch
Size: 2929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221026/5bd7eee6/attachment.bin>
More information about the llvm-commits
mailing list