[PATCH] D135693: [RegisterScavenger][RISCV] Don't search for FrameSetup instrs if we were searching from Non-FrameSetup instrs

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 23:55:16 PDT 2022


StephenFan added inline comments.


================
Comment at: llvm/lib/CodeGen/RegisterScavenging.cpp:376
     const MachineInstr &MI = *I;
+    // Don't search to FrameSetup instructions if we were searching from
+    // Non-FrameSetup instructions. Otherwise, the spill position may point
----------------
craig.topper wrote:
> Can this be done in the `FoundTo` path? Does this matter before we find `To`?
You are right. It doesn't matter before we find `To`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135693/new/

https://reviews.llvm.org/D135693



More information about the llvm-commits mailing list