[PATCH] D135345: [libunwind] Add module maps for libunwind

[Ian Anderson via Phabricator via llvm-commits]

iana marked an inline comment as done.
iana added inline comments.


================
Comment at: libunwind/include/mach-o/compact_unwind_encoding.modulemap:1
+module MachO.compact_unwind_encoding [system] {
+  header "compact_unwind_encoding.h"
----------------
ldionne wrote:
> iana wrote:
> > MaskRay wrote:
> > > Why is this not called `unwind.something`?
> > Because on Apple platforms it's part of the MachO module. This file is already present on Apple platforms, I'm just upstreaming it.
> I actually don't quite understand why we need this at all. We don't need to install that in `usr/include`, since it's only used to build the libunwind library.
This file installs in `usr/include/mach-o`, where `usr/include/macho-o/module.modulemap` extern's it.

```
module MachO [system] [extern_c] {
...
  extern module compact_unwind_encoding "compact_unwind_encoding.modulemap"

  module arch {
    header "arch.h"
    export *
  }
...
}
```

And again this file is already present in Apple's version of clang, I thought it made sense to upstream it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135345/new/

https://reviews.llvm.org/D135345