[PATCH] D134490: [NFC] check for UnreachableInst first as it is cheaper compared to getTerminatingDeoptimizeCall

[Peter Rong via Phabricator via llvm-commits]

Peter added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:504
          VisitedBlocks.insert(BB).second) {
-    if (BB->getTerminatingDeoptimizeCall() ||
-        isa<UnreachableInst>(BB->getTerminator()))
+    if (isa<UnreachableInst>(BB->getTerminator() ||
+        BB->getTerminatingDeoptimizeCall()))
----------------
Are we `bitwise or` two pointers of different type or is the parentheses wrong?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134490/new/

https://reviews.llvm.org/D134490