[PATCH] D136496: [bazel] Make labels to third-party dependencies explicit

Aaron Siddhartha Mondal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 15:56:18 PDT 2022


aaronmondal added a comment.

The way I am implementing these patches should not change anything for the current WORKSPACE build. The patches I will submit will look something like this:

1. This patch
2. A small compatibility patch for `clang/BUILD.bazel`, changing builtin_headers_gen to also accept paths that are not only `external/llvm-project/...`, since with bzlmod these paths will look different depending on the context.
3. A patch adding a bzlmod module extension that reuses `llvm_configure` from `configure.bzl`, a `MODULE.bazel` file and documentation/examples.

If I don't mess something up, the first two patches should be strictly generalizations of the current logic, so that the WORKSPACE build flow is untouched, but made compatible with bzlmod as well. Without an `--experimental_enable_bzlmod` in the `.bazelrc` the new extension and the MODULE file should be ignored by Bazel.

One thing to consider is that if we would want this run in CI similar to the `premerge-check` pipeline, the Bazel version in `.bazelversion` would need to be bumped to `5.3.2` (maybe 5.3.0 suffices), which should be backwards compatible with `5.0.0`, but contains some bugfixes for bzlmod wich are required for all of this to work with in-tree builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136496/new/

https://reviews.llvm.org/D136496



More information about the llvm-commits mailing list