[PATCH] D134201: [Sparc] Fix useDeprecatedPositionallyEncodedOperands errors.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 15:45:57 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LDSTUBrr/LDSTUBri have differences as mentioned. Is the `   case 74:` difference expected?

  % diff -ur /tmp/{old,new}
  diff -ur /tmp/old/lib/Target/Sparc/SparcGenDisassemblerTables.inc /tmp/new/lib/Target/Sparc/SparcGenDisassemblerTables.inc
  --- /tmp/old/lib/Target/Sparc/SparcGenDisassemblerTables.inc    2022-10-25 15:43:12.603059757 -0700
  +++ /tmp/new/lib/Target/Sparc/SparcGenDisassemblerTables.inc    2022-10-25 15:44:15.299347605 -0700
  @@ -1511,9 +1511,9 @@
   /* 6918 */    MCD::OPC_ExtractField, 13, 1,  // Inst{13} ...
   /* 6921 */    MCD::OPC_FilterValue, 0, 11, 0, 0, // Skip to: 6937
   /* 6926 */    MCD::OPC_CheckField, 5, 8, 0, 99, 4, 0, // Skip to: 8056
  -/* 6933 */    MCD::OPC_Decode, 174, 4, 4, // Opcode: LDSTUBrr
  +/* 6933 */    MCD::OPC_Decode, 174, 4, 17, // Opcode: LDSTUBrr
   /* 6937 */    MCD::OPC_FilterValue, 1, 90, 4, 0, // Skip to: 8056
  -/* 6942 */    MCD::OPC_Decode, 173, 4, 4, // Opcode: LDSTUBri
  +/* 6942 */    MCD::OPC_Decode, 173, 4, 17, // Opcode: LDSTUBri
   /* 6946 */    MCD::OPC_FilterValue, 14, 28, 0, 0, // Skip to: 6979
   /* 6951 */    MCD::OPC_ExtractField, 13, 1,  // Inst{13} ...
   /* 6954 */    MCD::OPC_FilterValue, 0, 11, 0, 0, // Skip to: 6970
  @@ -2312,6 +2312,8 @@
       if (DecodeSWAP(MI, insn, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
       return S;
     case 74:
  +    tmp = fieldFromInstruction(insn, 25, 5);
  +    if (DecodeIntRegsRegisterClass(MI, tmp, Address, Decoder) == MCDisassembler::Fail) { return MCDisassembler::Fail; }
       tmp = fieldFromInstruction(insn, 5, 8);
       MI.addOperand(MCOperand::createImm(tmp));
       return S;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134201/new/

https://reviews.llvm.org/D134201



More information about the llvm-commits mailing list