[PATCH] D136698: [SampleFDO] Persist profile staleness metrics into binary

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 14:59:55 PDT 2022


wenlei added a comment.

In D136698#3883720 <https://reviews.llvm.org/D136698#3883720>, @davidxl wrote:

> The use case of the feature is still  a little fuzzy to me. Why is the mismatch issue not caught and handled at build time?

With fleet-wide profiling for sample PGO, there's no much people can do at build time if we don't want to block builds when stale profile is found. And it's also not that scalable to address it at build time for thousands of services. We aim to build a system that monitors profile staleness for thousands of services using sample pgo, which then drives the operational work of tightening up PGO pipeline (done by people outside of compiler team). This is the compiler part for collecting such data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136698/new/

https://reviews.llvm.org/D136698



More information about the llvm-commits mailing list