[PATCH] D136164: [MemorySSA] Use BatchAA for clobber walker

[Konstantina Mitropoulou via Phabricator via llvm-commits]

kmitropoulou added a comment.
Herald added a reviewer: kmitropoulou.

In D136164#3882569 <https://reviews.llvm.org/D136164#3882569>, @nikic wrote:

> Ping :)
>
> In D136164#3865041 <https://reviews.llvm.org/D136164#3865041>, @foad wrote:
>
>>> e.g. for NewGVN I think we should be able to use a single BatchAA instance for all queries.
>>
>> @kmitropoulou it sounds like this could help with NewGVN compile time.
>
> Without looking too deeply into it, it's likely that the changes proposed by @kmitropoulou would actually prevent sharing BatchAA for all queries, because they introduce IR changes to the analysis phase, while NewGVN is generally designed to separate analysis and transformation.

Load coercion does a similar thing to phi-of-ops transformation. Both transformations find optimizations opportunities during analysis. Both transformations emit new code after the analysis. The only difference is the point where the two transformations emit the new code. In case of phi-of-ops transformation, the new phi nodes are emitted in eliminateInstructions(),. In case of load coercion, the new code is emitted just before eliminateInstructions() for the reasons that are mentioned here: https://reviews.llvm.org/D124071#inline-1188926 .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136164/new/

https://reviews.llvm.org/D136164