[PATCH] D136148: [AMDGPU][NFC] Split MC tests into promoted from VOP2 to VOP3 and only VOP3

Tue Oct 25 14:14:40 PDT 2022

dp added a comment.

In D136148#3883689 <https://reviews.llvm.org/D136148#3883689>, @Joe_Nash wrote:

> In D136148#3883668 <https://reviews.llvm.org/D136148#3883668>, @dp wrote:
>
>> The patch may be useful, but I’m concerned with file naming. I think the naming should be consistent. Right now we have `vop3`, `vop3c`, `vop3cx` and now `vop3_from…`. Maybe we should think over test naming?
>>
>> IMO `vop3_from_vop2_dpp16` is questionable.
>>
>> To tell you the truth, I considered splitting VOP3 opcodes into native and promoted parts but was unable to find good file names and abandoned the idea.
>>
>> Any proposals to make the naming consistent?
>
> vop3[_{dpp16,dpp8}][_from_{vopc,vopcx,vop1,vop2}] seems ok to me.

Fine with me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136148/new/

https://reviews.llvm.org/D136148