[PATCH] D136676: [AMDGPU] Speedup SIFormMemoryClauses live-in register set calculation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:280
 
-  for (MachineBasicBlock &MBB : MF) {
-    GCNDownwardRPTracker RPT(*LIS);
+  SmallVector<MachineInstr *, 16> FirstBBClauseMI;
+  for (auto &MBB : MF) {
----------------
vpykhtin wrote:
> arsenm wrote:
> > You seem to be assuming a single clause per block. I'd expect to handle this a full clause in a time, within a single block.
> Not quite, I just compute the live-in set for the first clause per BB to reset the RPTracker, then it is advanced to the next clause.
Can you do this per block, instead of calculating this for every block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136676/new/

https://reviews.llvm.org/D136676