[PATCH] D136627: [SampleFDO] Compute profile mismatch metrics

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 12:08:47 PDT 2022


wlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2154
+  if (FunctionSamples::ProfileIsProbeBased) {
+    dbgs() << "(" << NumMismatchedFuncHash << "/" << TotalProfiledFunc << ")"
+           << " of functions' profile are invalid and "
----------------
hoy wrote:
> Still seeing ` dbgs()` here. Should it be `stderr`?
I see, I thought dbgs() is the same thing to errs() for non-debug mode.. changed to `errs()`, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136627/new/

https://reviews.llvm.org/D136627



More information about the llvm-commits mailing list