[PATCH] D136636: [llvm-readelf] --section-details: display SHF_COMPRESSED headers

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4196
+    if (!Data || Data->size() < sizeof(Elf_Chdr)) {
+      consumeError(Data.takeError());
+      OS << "[<corrupt>]";
----------------
jhenderson wrote:
> I'm wondering if we should report this error as a warning. It might help the user know why their section is corrupt, for example.
The GNU behavior is `[<corrupt>]`. Do you suggest a separate warning beside the stdout output?  That may duplicate the information...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136636/new/

https://reviews.llvm.org/D136636