[PATCH] D135041: [ObjCARC] Remove legacy PM versions of optimization passes

Tue Oct 25 08:00:03 PDT 2022

aeubanks added inline comments.

================
Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:2486

 void ObjCARCOpt::releaseMemory() {
   PA.clear();
----------------
uabelho wrote:
> Looks like this method is unused after this patch.
> gcc warns with
> ```
> 00:13:01 ../lib/Transforms/ObjCARC/ObjCARCOpts.cpp:2486:6: warning: 'void {anonymous}::ObjCARCOpt::releaseMemory()' defined but not used [-Wunused-function]
> 00:13:01  2486 | void ObjCARCOpt::releaseMemory() {
> 00:13:01       |      ^~~~~~~~~~
> ```
> Can we remove it or is will it be used somewhere?
sorry about that, somebody fixed this in https://reviews.llvm.org/D136665

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135041/new/

https://reviews.llvm.org/D135041