[PATCH] D135345: [libunwind] Add module maps for libunwind

Tue Oct 25 07:23:40 PDT 2022

ldionne added a comment.

In D135345#3880719 <https://reviews.llvm.org/D135345#3880719>, @MaskRay wrote:

> IIUC non-Mach-O platforms will probably not benefit from `libunwind.modulemap`.

Why not? Isn't it the same as with libc++ providing its own modulemap? Sorry if that's a naive question, but I don't see how any of this is specific to mach-o.

================
Comment at: libunwind/include/mach-o/compact_unwind_encoding.modulemap:1
+module MachO.compact_unwind_encoding [system] {
+  header "compact_unwind_encoding.h"
----------------
iana wrote:
> MaskRay wrote:
> > Why is this not called `unwind.something`?
> Because on Apple platforms it's part of the MachO module. This file is already present on Apple platforms, I'm just upstreaming it.
I actually don't quite understand why we need this at all. We don't need to install that in `usr/include`, since it's only used to build the libunwind library.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135345/new/

https://reviews.llvm.org/D135345