[PATCH] D136612: [lit][REQUIRES] Fix some tests with incorrect REQUIRES clauses
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 06:40:09 PDT 2022
probinson added inline comments.
================
Comment at: llvm/test/Analysis/BasicAA/cs-cs-arm.ll:3-4
+; REQUIRES: arm-registered-target
+; This hasn't been run in a long time and it no longer matches reality.
+; XFAIL: *
----------------
jhenderson wrote:
> Have you raised a bug for this?
Not yet. I was hoping someone who understood the test would provide guidance. If that's not happening, I will raise a bug when this goes in.
================
Comment at: llvm/test/CodeGen/Hexagon/abi-padding-2.ll:2
; RUN: llc -march=hexagon -mcpu=hexagonv65 < %s | FileCheck %s
-; REQUIRES: hexagon
----------------
jhenderson wrote:
> I'm not familiar with these tests, so this might be a silly question, but why isn't this required? Is it in the lit config?
Yes, test/CodeGen/Hexagon already marks the entire directory as unsupported unless hexagon is enabled. If it didn't, then this would have changed to `hexagon-registered-target`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136612/new/
https://reviews.llvm.org/D136612
More information about the llvm-commits
mailing list