[PATCH] D134195: [PowerPC] XCOFF exception section support on the integrated assembler path

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section.ll:5
+; RUN: llvm-readobj --syms %t.o | FileCheck %s --check-prefix=SYMS
+; RUN: llvm-objdump --section-headers %t.o | FileCheck %s --check-prefix=DUMP
+
----------------
pscoro wrote:
> DiggerLin wrote:
> > pscoro wrote:
> > > DiggerLin wrote:
> > > > is the test duplicate with
> > > > 
> > > > ; RUN: llvm-readobj --section-headers %t.o | FileCheck %s --check-prefix=READ ?
> > > > 
> > > No, the output of `llvm-readobj` and `llvm-objdump` with `--section-headers` are not the same.
> > you want to check the content of the .exception header? I think both check it.
> Yes, my thinking behind the `llvm-objdump` line was to test that the output of that command is correct in addition to the `llvm-readobj` output. I see that this is technically just testing that llvm-objdump is working correctly and isn't really adding anything to exception section testing, so I should just remove the `llvm-objdump` tests?
I think we should keep llvm-readobj  test. it have more detail info, at lease you also check following in the llvm-readobj test

; READ-NEXT:      Type: STYP_EXCEPT (0x100)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134195/new/

https://reviews.llvm.org/D134195