[PATCH] D136443: X86: use soft-float ABI for fp16 libcalls on Darwin

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fp-round.ll:5
-; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx | FileCheck %s --check-prefixes=AVX1
-; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512f,+avx512vl | FileCheck %s --check-prefixes=AVX512,AVX512F
-; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512fp16,+avx512vl | FileCheck %s --check-prefixes=AVX512,AVX512FP16
----------------
pengfei wrote:
> Why remove it? I think it helps reduce duplicated checks.
The update tool didn't make use of it for whatever reason and printed a warning. Maybe the comments etc?


================
Comment at: llvm/test/CodeGen/X86/fp-round.ll:596
+; AVX512FP16-LABEL: round_v16f32:
+; AVX512FP16:       ## %bb.0:
+; AVX512FP16-NEXT:    vpbroadcastd {{.*#+}} zmm1 = [4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1,4.9999997E-1]
----------------
pengfei wrote:
> One more `#`? Is it modified by manual? This should be updated by `utils/update_llc_test_checks.py` directly.
This is the `update_llc_test_checks.py` output. `CommentString` is "##" on Darwin for apparently historical reasons:

```
  // Use ## as a comment string so that .s files generated by llvm can go
  // through the GCC preprocessor without causing an error.  This is needed
  // because "clang foo.s" runs the C preprocessor, which is usually reserved
  // for .S files on other systems.  Perhaps this is because the file system
  // wasn't always case preserving or something.
```

Long before my time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136443/new/

https://reviews.llvm.org/D136443