[PATCH] D136629: [AMDGPU] Fix delay alu for VOPD with src2acc

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 03:23:30 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:8551
     for (unsigned SrcIdx = 0; SrcIdx < SrcOperandsNum; ++SrcIdx) {
-      addOp(InstInfo[CompIdx].getParsedSrcIndex(SrcIdx));
+      auto CInfo = InstInfo[CompIdx];
+      addOp(CInfo.getParsedSrcIndex(SrcIdx, CInfo.hasSrc2Acc()));
----------------
dp wrote:
> This may be moved out of the loop (together with `CInfo.hasSrc2Acc()`).
Maybe `const auto &` here and on the declaration of `InstInfo`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136629/new/

https://reviews.llvm.org/D136629



More information about the llvm-commits mailing list