[PATCH] D136332: [FuncSpec][NFC] Avoid redundant computations of DominatorTree/LoopInfo

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 02:18:32 PDT 2022


labrinea added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:607
   /// Compute a bonus for replacing argument \p A with constant \p C.
-  InstructionCost getSpecializationBonus(Argument *A, Constant *C) {
+  InstructionCost getSpecializationBonus(Argument *A, Constant *C, const LoopInfo &LI) {
     Function *F = A->getParent();
----------------
clang format this please, it exceeds the 80 char limit


================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:1535
 
+const LoopInfo &SCCPSolver::getLoopInfo(Function &F) { return Visitor->getLoopInfo(F); }
+
----------------
same here, clang format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136332/new/

https://reviews.llvm.org/D136332



More information about the llvm-commits mailing list