[PATCH] D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Thanks for all the effort @aeubanks ! Left some comments inline.



================
Comment at: llvm/docs/WritingAnLLVMNewPMPass.rst:239-240
+
+LLVM provides a mechanism to automatically register pass plugins within various
+tools like ``clang`` or ``opt``.  Create a CMake project at the root of the repo
+alongside other projects.  This project must contain the following minimal
----------------
To me, "automatic pass registration" equals "static registration". However, IIUC, this is meant to cover both "static" and "dynamic" registration. And the first sentence here suggests that only static/automatic registration is covered.


================
Comment at: llvm/docs/WritingAnLLVMNewPMPass.rst:256
+
+Pass plugins are compiled and link dynamically by default. Setting
+``LLVM_${NAME}_LINK_INTO_TOOLS`` to ``ON`` turns the project into a staticall
----------------



================
Comment at: llvm/docs/WritingAnLLVMNewPMPass.rst:257
+Pass plugins are compiled and link dynamically by default. Setting
+``LLVM_${NAME}_LINK_INTO_TOOLS`` to ``ON`` turns the project into a staticall
+linked extension.
----------------



================
Comment at: llvm/docs/WritingAnLLVMNewPMPass.rst:262
+
+To include statically linked pass plugins when building a tool that uses the new pass manager:
+
----------------
Can you elaborate a bit? This isn't needed for `Bye`, is it? So when would it be needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136626/new/

https://reviews.llvm.org/D136626