[PATCH] D135912: [PseudoProbe] Replace relocation with offset for entry probe.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 22:54:44 PDT 2022


wenlei added inline comments.


================
Comment at: llvm/include/llvm/MC/MCPseudoProbe.h:17-18
 // FUNCTION BODY (one for each outlined function present in the text section)
 //    GUID (uint64)
 //        GUID of the function
 //    NPROBES (ULEB128)
----------------
Have you considered removing this GUID field, but always require a sentinel probe for any (split) binary function including the main body? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135912/new/

https://reviews.llvm.org/D135912



More information about the llvm-commits mailing list