[PATCH] D131873: [PowerPC] Optimize compare by using record form in post-RA.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 22:51:15 PDT 2022


shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:2791
+  unsigned Opc = CmpMI.getOpcode();
+  if (Opc == PPC::CMPLWI || (Subtarget.isPPC64() && Opc == PPC::CMPLDI))
+    return false;
----------------
shchenz wrote:
> Maybe we don't need `Subtarget.isPPC64()` for  `PPC::CMPLDI` because this should be impossible.
I meant `isPPC32 && PPC::CMPLDI` is impossible, so that we don't need check `Subtarget.isPPC64()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131873/new/

https://reviews.llvm.org/D131873



More information about the llvm-commits mailing list