[llvm] 11ed12f - llvm-reduce: Remove pointless template arguments

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 22:32:37 PDT 2022


Author: Matt Arsenault
Date: 2022-10-24T22:32:31-07:00
New Revision: 11ed12f99f0451ca6ce4daf3c4134a2c9b0b30f4

URL: https://github.com/llvm/llvm-project/commit/11ed12f99f0451ca6ce4daf3c4134a2c9b0b30f4
DIFF: https://github.com/llvm/llvm-project/commit/11ed12f99f0451ca6ce4daf3c4134a2c9b0b30f4.diff

LOG: llvm-reduce: Remove pointless template arguments

Added: 
    

Modified: 
    llvm/tools/llvm-reduce/deltas/Delta.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-reduce/deltas/Delta.cpp b/llvm/tools/llvm-reduce/deltas/Delta.cpp
index 73a00e6261040..736e62361c546 100644
--- a/llvm/tools/llvm-reduce/deltas/Delta.cpp
+++ b/llvm/tools/llvm-reduce/deltas/Delta.cpp
@@ -150,11 +150,10 @@ static bool increaseGranularity(std::vector<Chunk> &Chunks) {
 
 // Check if \p ChunkToCheckForUninterestingness is interesting. Returns the
 // modified module if the chunk resulted in a reduction.
-template <typename FuncType>
 static std::unique_ptr<ReducerWorkItem>
 CheckChunk(Chunk &ChunkToCheckForUninterestingness,
            std::unique_ptr<ReducerWorkItem> Clone, TestRunner &Test,
-           FuncType ExtractChunksFromModule,
+           ReductionFunc ExtractChunksFromModule,
            std::set<Chunk> &UninterestingChunks,
            std::vector<Chunk> &ChunksStillConsideredInteresting) {
   // Take all of ChunksStillConsideredInteresting chunks, except those we've
@@ -206,10 +205,9 @@ CheckChunk(Chunk &ChunkToCheckForUninterestingness,
   return Clone;
 }
 
-template <typename FuncType>
-SmallString<0> ProcessChunkFromSerializedBitcode(
+static SmallString<0> ProcessChunkFromSerializedBitcode(
     Chunk &ChunkToCheckForUninterestingness, TestRunner &Test,
-    FuncType ExtractChunksFromModule, std::set<Chunk> &UninterestingChunks,
+    ReductionFunc ExtractChunksFromModule, std::set<Chunk> &UninterestingChunks,
     std::vector<Chunk> &ChunksStillConsideredInteresting,
     SmallString<0> &OriginalBC, std::atomic<bool> &AnyReduced) {
   LLVMContext Ctx;


        


More information about the llvm-commits mailing list