[PATCH] D135676: [AArch64]SME2 Multi-vector ternary indexed DOT and FMLA instructions

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 17:52:52 PDT 2022


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

One more request but otherwise looks good.



================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:468
+
+defm USVDOT_VG4_M4ZZI : sme2_multi_vec_array_vg4_index_32b<"usvdot", 0b0101, ZZZZ_b_mul_r, ZPR4b8>;
+
----------------
For consistency please can all the dot instructions have a suffix even when there's only a single variant of the instruction. Doing this makes it easier to know what the instruction does from the name alone. So for this case it'll be `USVDOT_VG4_M4ZZI_BtoS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135676/new/

https://reviews.llvm.org/D135676



More information about the llvm-commits mailing list