[PATCH] D136627: [SampleFDO] Compute profile mismatch metrics

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 16:39:41 PDT 2022


wlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2142
+
+  LLVM_DEBUG({
+    if (FunctionSamples::ProfileIsProbeBased) {
----------------
wenlei wrote:
> When the flag is on, we should always emit the messages, regardless of debug build or not. Same for the one below. 
Sounds good! Changed to use `outs`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136627/new/

https://reviews.llvm.org/D136627



More information about the llvm-commits mailing list