[PATCH] D136452: [bazel] Add missing C++ style clang headers

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added a comment.

In D136452#3880688 <https://reviews.llvm.org/D136452#3880688>, @chapuni wrote:

> FYI, I intend that `builtin_headers_gen` may be available for the target for packaging.
> Its contents shall be the same (or subset) of the installaed image by CMake.

Ah now it makes sense to me why we are excluding two headers.

Regarding the updated diff, it will work, but may go slightly against the guideline in https://bazel.build/reference/be/functions#glob, stating

> In general, you should try to provide an appropriate extension (e.g. *.html) instead of using a bare '*' for a glob pattern. The more explicit name is both self documenting and ensures that you don't accidentally match backup files, or emacs/vi/... auto-save files.

I don't think this is an issue in this particular case though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136452/new/

https://reviews.llvm.org/D136452