[PATCH] D136523: [MSAN] Add handleCountZeroes for vector versions of ctlz and cttz.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 14:55:21 PDT 2022


eugenis added a comment.

LGTM, but I'd merge the two changes. I don't really see the point of submitting a test for the broken behavior first.



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2982
+    // If zero poison is requested, mix in with the shadow
+    Value *BoolZeroPoison = ConstantInt::getFalse(BoolShadow->getType());
+    assert(isa<Constant>(I.getOperand(1)));
----------------
This line seems unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136523/new/

https://reviews.llvm.org/D136523



More information about the llvm-commits mailing list