[PATCH] D136452: [bazel] Add missing C++ style clang headers
NAKAMURA Takumi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 14:31:59 PDT 2022
chapuni added a comment.
FYI, I intend that `builtin_headers_gen` may be available for the target for packaging.
Its contents shall be the same (or subset) of the installaed image by CMake.
================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1478
+ "lib/Headers/**/*.h",
+ "lib/Headers/cuda_wrappers/algorithm",
+ "lib/Headers/cuda_wrappers/complex",
----------------
Seems odd to pass non-wildcard files to `glob`.
Instead, could we reorganize the pattern? Like,
* `lib/Headers/*.h`
* `lib/Headers/cuda_wrappers`
* `lib/Headers/openmp_wrappers`
* `lib/Headers/ppc_wrappers`
(`clang/lib/Headers/hlsl` may be excluded here for now, since HLSL is not enabled in bazel build)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136452/new/
https://reviews.llvm.org/D136452
More information about the llvm-commits
mailing list