[PATCH] D136395: Add the ability to verify the .debug_aranges section.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 14:31:08 PDT 2022


clayborg added a comment.

In D136395#3873072 <https://reviews.llvm.org/D136395#3873072>, @dblaikie wrote:

> If possible, I'd rather not add this - I think .debug_aranges should be removed (it's already been off-by-default for a decade in Clang) in favor of using CU-level address ranges. They're cheap-enough to parse that it doesn't substantially change the performance of tools so far as I'm aware and they save space by not duplicating the address range information in two places.
>
> Adding a verifier feels like endorsing/encouraging/maintaining `.debug_aranges` which seems like the wrong direction we should be going.

I believe the opposite in that if we can prove tools are having a tough time producing these accelerator tables correctly, it can be a reason to vote for removal of this section. I agree this section is not needed if the compile unit has a DW_AT_ranges attribute and would be happy to see this section go away.

But this section is part of the DWARF specification and I believe we should be able to verify it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136395/new/

https://reviews.llvm.org/D136395



More information about the llvm-commits mailing list