[PATCH] D136242: [IntervalMap] Add move and copy ctors and assignment operators

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 13:39:31 PDT 2022


dblaikie added inline comments.


================
Comment at: llvm/include/llvm/ADT/IntervalMap.h:1066-1069
+    if (RHS.branched())
+      rootBranch() = std::move(RHS.rootBranch());
+    else
+      rootLeaf() = std::move(RHS.rootLeaf());
----------------
This leaves the leaves the `rootBranch`/`rootLeaf` in a moved-from state, what does that mean for the state of the object? 

What's the state of a moved-from `IntervalMap`? Is there some test coverage for that? I'd expect to need to change the `height`/`rootSize` for the moved-from object in some way?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136242/new/

https://reviews.llvm.org/D136242



More information about the llvm-commits mailing list