[PATCH] D134950: [CodeGen] Allow targets to define vreg flags

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added a comment.

In D134950#3869851 <https://reviews.llvm.org/D134950#3869851>, @qcolombet wrote:

> Hi all,
>
> I've thought a little bit more about this.
> Could we handle this with the existing delegate mechanism? (Look at how `MRI_NoteNewVirtualRegister` works.)
>
> That way, you could do whatever target specific thing you want and it won't spill in the generic code.
> To do that we may have to lift the limitation that we have only one delegate at a time (and we may need to add a few more hooks to notify the delegate on the events you are interested in.)
>
> How does that sounds?
>
> Cheers,
> -Quentin

The delegate is not used in any target-specific passes so far. The specific cases they are currently used for, are looking reasonable. But I'm not really sure the delegate would be a good idea to handle the flags here. It seems like a more complicated way to propagate the flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134950/new/

https://reviews.llvm.org/D134950